dpcollins-google commented on a change in pull request #15537:
URL: https://github.com/apache/beam/pull/15537#discussion_r712409400



##########
File path: 
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/pubsublite/ReadWriteIT.java
##########
@@ -236,6 +236,8 @@ public void testReadWrite() throws Exception {
     pipeline.getOptions().as(TestPipelineOptions.class).setBlockOnRun(false);
 
     TopicPath topic = createTopic(getProject(pipeline.getOptions()));
+    // Sleep for topic creation to propagate.
+    Thread.sleep(10000);

Review comment:
       I've made this into a loop which will try up to 30 times, retrying 
errors after a 1 second sleep. It builds in a longer potential latency without 
impacting the average case.
   
   Speaking now with system knowledge, the read which is flaky uses bounded 
staleness of 30 seconds, which means this loop should always outlive the race 
condition.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to