youngoli commented on a change in pull request #15094:
URL: https://github.com/apache/beam/pull/15094#discussion_r712472048
##########
File path: sdks/go/test/integration/io/xlang/kafka/jar.go
##########
@@ -13,13 +13,18 @@
// See the License for the specific language governing permissions and
// limitations under the License.
+// Exclude OSes which do not support the timeout command or syscall.SIGTERM.
Review comment:
Done, added checks for the timeout command (and the java command while
I'm at it) and even added a way for people to run the test without timeout if
their system doesn't support it, and added slightly better non-unix OS support.
As an aside, the ideal solution to this problem of Kafka cluster jars
sticking around is to change our implementation of these jars to include an
auto-shutdown within the jar itself. That way it'll always clean itself up,
regardless of Beam SDK or OS used. Maybe I should make a Jira for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
