youngoli commented on pull request #15530:
URL: https://github.com/apache/beam/pull/15530#issuecomment-923559695


   Ack. In situations like this I'd suggest adding a TODO or comment 
documenting that the side input cache field doesn't actually do anything, since 
it's really easy for unfamiliar readers to assume otherwise.
   
   Anyway, approved pending a comment/TODO.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to