reuvenlax commented on a change in pull request #15465:
URL: https://github.com/apache/beam/pull/15465#discussion_r716256510
##########
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/ParDoEvaluator.java
##########
@@ -100,7 +101,8 @@
windowingStrategy,
doFnSchemaInformation,
sideInputMapping);
- if (DoFnSignatures.signatureForDoFn(fn).usesState()) {
+ DoFnSignature signature = DoFnSignatures.signatureForDoFn(fn);
+ if (signature.usesState() || signature.onWindowExpiration() != null) {
Review comment:
Yes, though it could also be separated. OnWindowExpiration didn't work
if there were no state variables, which caused some of the tests I added to
fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
