lostluck commented on a change in pull request #15482:
URL: https://github.com/apache/beam/pull/15482#discussion_r717174187
##########
File path: sdks/go/pkg/beam/core/metrics/metrics.go
##########
@@ -529,6 +561,21 @@ func (r CounterResult) Result() int64 {
return r.Attempted
}
+// Name returns the Name value from the Key field.
+func (r CounterResult) Name() string {
+ return r.Key.Name
+}
+
+// Namespace returns the Namespace value from the Key field.
Review comment:
```suggestion
// Namespace returns the Namespace of this Counter.
```
and similar for Gauge and Distribution
##########
File path: sdks/go/pkg/beam/core/metrics/metrics.go
##########
@@ -529,6 +561,21 @@ func (r CounterResult) Result() int64 {
return r.Attempted
}
+// Name returns the Name value from the Key field.
Review comment:
```suggestion
// Name returns the Name of this Counter.
```
and similar for Gauge and Distribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
