brachi-wernick commented on pull request #15510:
URL: https://github.com/apache/beam/pull/15510#issuecomment-930457576


   Creating more extendable coder is definitely better, I would suggest the 
bellow:
   
   1. Add `MetadataCoder` the ability to get list of fields names needed to be 
encoded/decode.
   2. `ReadableFileCoder` will get `MetadataCoder` instance in its constructor 
parameters. to make the configuration and adjustments  only in one 
place(`MetadataCoder`) 
   
   We can make this also in 2 phases-PRs, (start with number 2 just to solve 
the current issue and then enhance MetadataCoder for next future fields)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to