egalpin commented on pull request #15381: URL: https://github.com/apache/beam/pull/15381#issuecomment-931264027
Thanks for clarifying, that makes sense 👍 My original intent was to leave windows alone entirely and just output without modification. The challenge arose from the use of FinishBundle, where the output method requires explicit use of a BoundedWindow. So all of the window collection/multimap/adapter complexity is all done so that we could output any buffered elements when FinishBundle is called. If FinishBundle could accept a MultiOutput or OutputReceiver, I believe this would be solved neatly. I just didn’t want to gate this change on FinishBundle changes, but maybe that’s the right path? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
