damondouglas commented on a change in pull request #15626: URL: https://github.com/apache/beam/pull/15626#discussion_r719689777
########## File path: playground/frontend/lib/config/theme.dart ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import 'package:flutter/material.dart'; +import 'package:playground/config/colors.dart'; + +// TODO: add support for dart theme +final theme = ThemeData( + brightness: Brightness.light, + primaryColor: LightColor.primary, + backgroundColor: LightColor.primaryBackground, + appBarTheme: const AppBarTheme( + color: LightColor.secondaryBackground, + elevation: 1, + centerTitle: false, + ), +); + +class ThemeColors { + static Color greyColor(BuildContext context) { Review comment: The use of `BuildContext` here may not be necessary. I think the readability of this may be improved along with the comments addressed [here](https://github.com/apache/beam/pull/15626/files#r719679516) when refactoring the design of theme data configuration and constants. I struggled with the readability of this method serving as a getter. If this is still needed, dart has syntax sugar with getters that looks like this: ```dart class MyClass { int _sum = 0; void add(int value) { _sum += value; } int get sum() { return _sum; } // alternatively: int get sum => _sum; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
