kmjung commented on a change in pull request #15602:
URL: https://github.com/apache/beam/pull/15602#discussion_r719768878
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1914,11 +2310,30 @@ class ReadFromBigQuery(PTransform):
to create and delete tables within the given dataset. Dataset name
should *not* start with the reserved prefix `beam_temp_dataset_`.
"""
+ class Method(object):
+ EXPORT = 'EXPORT' # This is currently the default.
+ DIRECT_READ = 'DIRECT_READ'
Review comment:
I'm not sure that I have a sense of what Beam values here (consistency
across languages vs. consistency with external naming). I guess my slight
preference would be for the former, which would mean carrying over the
`DIRECT_READ` name. @satybald @pabloem @chamikaramj what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
