lukecwik commented on a change in pull request #15634:
URL: https://github.com/apache/beam/pull/15634#discussion_r719865537
##########
File path: sdks/python/apache_beam/runners/worker/operations.py
##########
@@ -710,13 +710,12 @@ def start(self):
def process(self, o):
# type: (WindowedValue) -> None
with self.scoped_process_state:
- delayed_application = self.dofn_runner.process(o)
- if delayed_application:
+ delayed_applications = self.dofn_runner.process(o)
+ if delayed_applications:
assert self.execution_context is not None
- # TODO(BEAM-77746): there's disagreement between subclasses
- # of DoFnRunner over the return type annotations of process().
- self.execution_context.delayed_applications.append(
- (self, delayed_application)) # type: ignore[arg-type]
+ for delayed_application in delayed_applications:
Review comment:
If the tests keep passing with the validates runner tests for SDF for a
couple of runners that support portable execution (e.g. Flink/Dataflow) then we
should merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
