ibzib commented on a change in pull request #15691:
URL: https://github.com/apache/beam/pull/15691#discussion_r725295294



##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -1147,6 +1151,9 @@ Merge all of the website pull requests
 Create and push a new signed tag for the released version by copying the tag 
for the final release candidate, as follows:
 
 ```
+# Optional: unlock the signing key by signing an arbitrary file.
+gpg --output ~/doc.sig --sign ~/.bashrc

Review comment:
       I tried this and got `gpg: signing failed: Timeout`. not sure why

##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -551,6 +551,10 @@ See the source of the script for more details, or to run 
commands manually in ca
 
 ### Run build_release_candidate.sh to create a release candidate
 
+Before you start, run this command to make sure you'll be using the latest 
docker images:
+
+      docker system prune -a

Review comment:
       Docker images for the release should all be tagged by RC. I'm not sure 
which image you were referring to in the PR description?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to