pabloem commented on a change in pull request #15441:
URL: https://github.com/apache/beam/pull/15441#discussion_r725314837
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##########
@@ -471,9 +559,17 @@ def _collect_written_timers(
timer_watermark_data[(transform_id, timer_family_id)] = min(
timer_watermark_data[(transform_id, timer_family_id)],
decoded_timer.hold_timestamp)
- newly_set_timers[(transform_id, timer_family_id)] = ListBuffer(
- coder_impl=timer_coder_impl)
- newly_set_timers[(transform_id, timer_family_id)].append(out.get())
+ else:
+ # Timer was cleared, so we must skip setting it below.
+ timer_cleared = True
+ continue
+ if timer_cleared or (transform_id,
Review comment:
ah great observation Yichi.... I've changed this code - we keep timers
per dynamic timer tag, and ew clean up only previous sets - but allow new sets
to work - so we'll only use the LATEST action on the timer.
Pushing code in a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
