pcoet commented on a change in pull request #15653:
URL: https://github.com/apache/beam/pull/15653#discussion_r725400750
##########
File path: website/www/site/layouts/partials/head.html
##########
@@ -35,15 +35,30 @@
.body__contained img { max-width: 100% }
</style>
-<script src="/js/bootstrap.min.js"></script>
+{{ $bootstrap := resources.Get "js/bootstrap.min.js" | minify | fingerprint }}
+<script type="text/javascript" src="{{ $bootstrap.RelPermalink }}"
defer></script>
+
<!-- TODO [BEAM-12644]: Create an asset pipeline so we don't have to version
.js files. -->
-<script src="/js/language-switch-v2.js"></script>
-<script src="/js/fix-menu.js"></script>
-<script src="/js/section-nav.js"></script>
-<script src="/js/page-nav.js"></script>
-<script src="/js/expandable-list.js"></script>
-<script src="/js/copy-to-clipboard.js"></script>
-<script src="/js/calendar.js"></script>
+{{ $switchV2 := resources.Get "js/language-switch-v2.js" | minify |
fingerprint }}
+<script type="text/javascript" src="{{ $switchV2.RelPermalink }}"
defer></script>
+
+{{ $fixMenu := resources.Get "/js/fix-menu.js" | minify | fingerprint }}
Review comment:
You're using an absolute path here: `/js/...`. Is that intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
