damondouglas commented on a change in pull request #15700: URL: https://github.com/apache/beam/pull/15700#discussion_r727224542
########## File path: playground/frontend/lib/modules/output/components/output_header/output_header.dart ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import 'package:flutter/material.dart'; +import 'package:playground/constants/sizes.dart'; +import 'package:playground/modules/output/components/output_header/output_placements.dart'; + +import 'output_tabs.dart'; + +class OutputHeader extends StatelessWidget { + const OutputHeader({Key? key}) : super(key: key); + + @override + Widget build(BuildContext context) { + return SizedBox( + height: 50, + child: Padding( + padding: const EdgeInsets.symmetric( + horizontal: kLgSpacing, + vertical: kZeroSpacing, + ), + child: Row( Review comment: For a future PR and **not** blocking for this PR: When I clicked on either the OutputPlacement left or right buttons, I saw a RenderFlex overflowed error: ``` ======== Exception caught by rendering library ===================================================== The following assertion was thrown during layout: A RenderFlex overflowed by 16 pixels on the right. The relevant error-causing widget was: Row Row:.../beam/playground/frontend/lib/modules/output/components/output_header/output_header.dart:37:16 The overflowing RenderFlex has an orientation of Axis.horizontal. The edge of the RenderFlex that is overflowing has been marked in the rendering with a yellow and black striped pattern. This is usually caused by the contents being too big for the RenderFlex. ``` My browser size was roughly 700 x 700. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
