TheNeuralBit commented on pull request #15410: URL: https://github.com/apache/beam/pull/15410#issuecomment-942504703
Hm I think ideally we'd keep the test, but skip it in the Go implementation and add a TODO with a jira, similar to what is done here: https://github.com/apache/beam/blob/7e896ba429fdad0b54448409cff95bdfd1d03e92/sdks/go/test/regression/coders/fromyaml/fromyaml.go#L86-L90 I'm not sure if there's a good way to skip payloads that specify an encoding_position though, we can't just string match like the example above. Do you have any suggestions @lostluck? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
