MarcoRob commented on a change in pull request #15572: URL: https://github.com/apache/beam/pull/15572#discussion_r728377024
########## File path: sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/PulsarIO.java ########## @@ -0,0 +1,185 @@ +package org.apache.beam.sdk.io.pulsar; + +import org.apache.beam.sdk.io.range.OffsetRange; +import org.apache.beam.sdk.transforms.DoFn; +import org.apache.beam.sdk.transforms.splittabledofn.GrowableOffsetRangeTracker; +import org.apache.beam.sdk.transforms.splittabledofn.RestrictionTracker; +import org.apache.pulsar.client.admin.PulsarAdmin; +import org.apache.pulsar.client.admin.PulsarAdminException; +import org.apache.pulsar.client.api.*; +import org.apache.pulsar.client.util.MessageIdUtils; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Supplier; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Suppliers; + +import java.io.IOException; +import java.util.List; +import java.util.concurrent.TimeUnit; + [email protected] +public class PulsarIO<K, V> extends DoFn<PulsarSource, PulsarRecord<K,V>> { Review comment: Okey, got it. Then I should do something similar like KafkaIO line #1344, right? https://github.com/apache/beam/blob/22205ee1a84581e9206c5c61bad88a799779b4bc/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java#L1344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
