benWize commented on a change in pull request #15648:
URL: https://github.com/apache/beam/pull/15648#discussion_r728543249
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/renderer/PortablePipelineDotRenderer.java
##########
@@ -104,8 +102,8 @@ private void exitBlock() {
indent -= 4;
}
- @FormatMethod
- private void writeLine(@FormatString String format, Object... args) {
+ @SuppressWarnings("AnnotateFormatMethod")
+ private void writeLine(String format, Object... args) {
Review comment:
Most of the problems with `@FormatMethod` were related to failures in
`analyzeDependencies` task, throwing `usedUndeclaredDependency: errorprone..`
I've added errorprone as compileOnly dependency in
https://github.com/apache/beam/blob/6563caf3d83af2a18a8a1d306ae378d46cf17023/sdks/java/testing/nexmark/build.gradle#L87
and
https://github.com/apache/beam/blob/6563caf3d83af2a18a8a1d306ae378d46cf17023/runners/core-construction-java/build.gradle#L66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
