dmitriikuzinepam commented on a change in pull request #15667:
URL: https://github.com/apache/beam/pull/15667#discussion_r730655011
##########
File path: sdks/python/apache_beam/io/textio.py
##########
@@ -561,6 +570,7 @@ def __init__(
skipped from each source file. Must be 0 or higher. Large number of
skipped lines might impact performance.
coder (~apache_beam.coders.coders.Coder): Coder used to decode each line.
+ delimiter (str or bytes): delimiter to split records
Review comment:
@nikie
> if readbuffer ends in the middle of a multi-byte delimiter
Can you give example please?
> Actually, the default for the delimiter delimiter=b'\n', is a bit
misleading, since under the hood it continues to split on both \n and \r\n
currently.
Yes, I agree, it should be fixed. I decided not to touch default behavior
the function on Python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
