egalpin commented on a change in pull request #15381:
URL: https://github.com/apache/beam/pull/15381#discussion_r731102223
##########
File path:
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
##########
@@ -1636,11 +1806,15 @@ public void processElement(ProcessContext c) throws
IOException {
* cluster. This class is effectively a thin proxy for DocToBulk->BulkIO
all-in-one for
* convenience and backward compatibility.
*/
- public static class Write extends PTransform<PCollection<String>, PDone> {
+ public static class Write extends PTransform<PCollection<String>,
PCollectionTuple> {
Review comment:
This actually raised a question for me. In the case where a user selects
that errors should be raised rather than returned via PCollectionTuple, and
where there are no errors, is the PDone implicit? Is there an issue with no
longer explicitly `returning PDone.in(...)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
