echauchot commented on a change in pull request #15381:
URL: https://github.com/apache/beam/pull/15381#discussion_r731695328
##########
File path:
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
##########
@@ -1636,11 +1806,15 @@ public void processElement(ProcessContext c) throws
IOException {
* cluster. This class is effectively a thin proxy for DocToBulk->BulkIO
all-in-one for
* convenience and backward compatibility.
*/
- public static class Write extends PTransform<PCollection<String>, PDone> {
+ public static class Write extends PTransform<PCollection<String>,
PCollectionTuple> {
Review comment:
PDone is more of a tagging class : does no configuration and has no
PValue (superclass of PCollection) in expand(). It should be ok but the best is
to add a test to ensure that the pipeline actually finishes in that particular
case. All the other combinations of error/isThrowErrors either throw a
RuntimeException or output a PCollectionTuple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
