pabloem commented on a change in pull request #15610:
URL: https://github.com/apache/beam/pull/15610#discussion_r732244061
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -785,10 +785,10 @@ def split(self, desired_bundle_size, start_position=None,
stop_position=None):
self.table_reference.projectId = self._get_project()
schema, metadata_list = self._export_files(bq)
- self.split_result = [
+ self.split_result = (
Review comment:
the advantage is that we don't need to hold all of the source objects in
memory at a single time. BQ generates ~ 5k files per TB exported. Some users
export tens of TBs (or hundreds!), which adds up to XXk files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
