aaltay commented on pull request #15105: URL: https://github.com/apache/beam/pull/15105#issuecomment-947298373
> Good idea. I added tests for all 3 cases in `Stager._download_file`. It is also working on wordcount example and our internal usage. @aaltay Please let me know what else you need from me! Otherwise seems like it's ready to be merged. Thanks. Thank you and this is excellent. Could you please fix the formatting issue on the new file? You can follow this: https://cwiki.apache.org/confluence/display/BEAM/Python+Tips#PythonTips-LintandFormattingChecks Or apply the delta from the failed test output manually: https://ci-beam.apache.org/job/beam_PreCommit_PythonFormatter_Commit/8385/console (delta near the bottom of the log.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
