mbenenso commented on a change in pull request #15434: URL: https://github.com/apache/beam/pull/15434#discussion_r732563532
########## File path: sdks/java/io/deltalake/src/main/java/io/delta/standalone/DeltaLog.java ########## @@ -0,0 +1,99 @@ +/* + * Copyright (2020) The Delta Lake Project Authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package io.delta.standalone; Review comment: I was not able to make working code with maven dependency: deltalake standalone use dependency that conflict with Beam, that are used in Scala's trait, so when I exclude this dependency & include Beam compatible, compilation is successful, but I get a runtime error. It would be nice to use Maven dependency and not include all source files, but I have not found the way how to do it, and the version that include source files works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
