mbenenso commented on pull request #15434: URL: https://github.com/apache/beam/pull/15434#issuecomment-947486482
Thanks, @pabloem, I have addressed you comments in my fork repo https://github.com/mbenenso/beam, but the changes are not reflected in the PR https://github.com/apache/beam/pull/15434. Is it normal? There is one more thing that I need help: convert pom.xml to build.gradle. Both java & scala should be compiled, so it is not a simple copy/paste operation. Please, let me know if Zoom call will help, and we'll schedule it. On Tue, Oct 19, 2021 at 1:18 PM Pablo ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > sdks/java/examples/deltalake/data/delta-lake-stream-03/_delta_log/00000000000000000002.json > <https://github.com/apache/beam/pull/15434#discussion_r732212614>: > > > @@ -0,0 +1,5 @@ > +{"commitInfo":{"timestamp":1625288960258,"operation":"STREAMING UPDATE","operationParameters":{"outputMode":"Append","queryId":"32bdce17-fd78-4b6b-a142-bdb29c874d9c","epochId":"2"},"readVersion":1,"isBlindAppend":true,"operationMetrics":{"numRemovedFiles":"0","numOutputRows":"35","numOutputBytes":"5163","numAddedFiles":"3"}}} > +{"txn":{"appId":"32bdce17-fd78-4b6b-a142-bdb29c874d9c","version":2,"lastUpdated":1625288960258}} > > this may not be necessary, but I see that delta lake also compresses json > files into parquet subfiles. Does it make sense to add that kind of file? > (maybe you're doing it in test code and I haven't gotten there) > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/15434#pullrequestreview-783743459>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AVJGAQBBKU5MSJESF4NHR5LUHXHCJANCNFSM5DFKT72A> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- Thanks ------------------------------ Michael Benenson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
