lukecwik commented on a change in pull request #15685:
URL: https://github.com/apache/beam/pull/15685#discussion_r733833118
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/testing/PAssert.java
##########
@@ -698,11 +715,16 @@ public PCollectionContentsAssert(
* <p>Returns this {@code IterableAssert}.
*/
@SafeVarargs
- final PCollectionContentsAssert<T> containsInAnyOrder(
+ @Override
+ public final PCollectionContentsAssert<T> containsInAnyOrder(
SerializableMatcher<? super T>... elementMatchers) {
return
satisfies(SerializableMatchers.containsInAnyOrder(elementMatchers));
}
+ @Override public PCollectionContentsAssert<T> containsInAnyOrder() {
+ return empty();
+ }
Review comment:
```suggestion
@Override
public PCollectionContentsAssert<T> containsInAnyOrder() {
return empty();
}
```
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/testing/PAssert.java
##########
@@ -299,6 +299,23 @@ public int hashCode() {
*/
IterableAssert<T> containsInAnyOrder(T... expectedElements);
+ /**
+ * Asserts that the iterable in question matches the provided elements.
+ *
+ * @return the same {@link IterableAssert} builder for further assertions
+ */
+ IterableAssert<T> containsInAnyOrder(SerializableMatcher<? super T>...
expectedElements);
+
+ /**
+ * Asserts that the iterable in question is empty.
+ *
+ * @deprecated Prefer {@link #empty()} to this method.
+ *
+ * @return the same {@link IterableAssert} builder for further assertions
Review comment:
```suggestion
* @return the same {@link IterableAssert} builder for further assertions
* @deprecated Prefer {@link #empty()} to this method.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
