dpcollins-google commented on a change in pull request #15727:
URL: https://github.com/apache/beam/pull/15727#discussion_r733946521
##########
File path: sdks/python/apache_beam/io/gcp/pubsublite/external.py
##########
@@ -0,0 +1,119 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
Review comment:
> This was mainly for consistency with existing I/O connectors.
Going to push back on this, IMO, all existing I/O connectors should be
pushed into a submodule. It better isolates the available classes, and allows
for the set of public classes to be easily defined in an __init__.py file
without needing to change user code if the structure of the files change in the
future.
I'd rather have a submodule giving us a clear place to add adaptors in the
future: for example, its likely that a port of CloudPubsubTransforms.java will
be requested at some point, and I'd prefer not to need one single thousand LOC
file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
