lostluck commented on a change in pull request #15642:
URL: https://github.com/apache/beam/pull/15642#discussion_r733977392
##########
File path: sdks/go/pkg/beam/util/execx/exec.go
##########
@@ -24,10 +24,22 @@ import (
// Execute runs the program with the given arguments. It attaches stdio to the
// child process.
func Execute(prog string, args ...string) error {
+ return ExecuteEnv(nil, prog, args...)
+}
+
+// Execute runs the program with the given arguments with additional
environment
+// variables. It attaches stdio to the child process.
+func ExecuteEnv(env map[string]string, prog string, args ...string) error {
Review comment:
Godoc style requires comments on exported identifiers to be of the form
`// <litteral name> ....`
So here it should be `// ExecuteEnv` .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
