nikie commented on pull request #15775: URL: https://github.com/apache/beam/pull/15775#issuecomment-950928284
@dmitriikuzinepam , I added a couple of comments to the Jira ticket BEAM-12730. Would you like to add delimiter param into the `apache_beam.io.textio.ReadAllFromText` transform as well? It uses the same `_TextSource` as `ReadFromText` through `source_from_file` partial, so should be easy: https://github.com/apache/beam/blob/1f08d1f3ddc2e7bc7341be4b29bdafaec18de9cc/sdks/python/apache_beam/io/textio.py#L501 We also need to think about self-overlapping delimiters, restricted in Java SDK. The easiest way would be to also restrict them here (see the ticket's comment). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
