robertwb commented on a change in pull request #15757:
URL: https://github.com/apache/beam/pull/15757#discussion_r736757062
##########
File path: sdks/python/apache_beam/transforms/combiners.py
##########
@@ -365,6 +365,10 @@ def push(hp, e):
for element in bundle
]
continue
+ # TODO(robertwb): Remove once legacy dataflow correctly handles
Review comment:
That is correct; when running in the legacy runner the fact that this
should be a list (per its type hint) is lost and it gets an abstract iterable
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
