ihji commented on a change in pull request #15692:
URL: https://github.com/apache/beam/pull/15692#discussion_r737107524
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -572,7 +572,8 @@ def _stage_resources(self, pipeline, options):
raise RuntimeError('The --temp_location option must be specified.')
resources = []
- hashes = {}
+ path_hashes = {}
Review comment:
Because the hash field is not always available from the proto. We might
also fix every file artifact payload generation that it creates the proto with
both path and hash fields but still this PR prevents a future mistake when
someone just forgets to populate the hash field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
