dmitriikuzinepam commented on pull request #15775:
URL: https://github.com/apache/beam/pull/15775#issuecomment-952693150


   > > > We also need to think about self-overlapping delimiters, restricted in 
Java SDK. The easiest way would be to also restrict them here (see the ticket's 
comment).
   > > 
   > > 
   > > Let's do it in other ticket, because current ticket is becoming to long
   > 
   > This is already done in this commit: 
[bc18afe](https://github.com/apache/beam/commit/bc18afe74636a48c04396483f51caa152320737e)
 Without this using self-overlapping delimiter would cause very rare data loss 
issues. And introducing this change after custom delimiter feature is released 
would mean backward incompatible changes.
   
   I have merged to my PR, thanks a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to