mosche commented on a change in pull request #15788:
URL: https://github.com/apache/beam/pull/15788#discussion_r737302703
##########
File path:
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/KinesisIO.java
##########
@@ -338,8 +341,33 @@ public Read withAWSClientsProvider(String awsAccessKey,
String awsSecretKey, Reg
*/
public Read withAWSClientsProvider(
String awsAccessKey, String awsSecretKey, Region region, String
serviceEndpoint) {
+ AwsCredentialsProvider awsCredentialsProvider =
+
StaticCredentialsProvider.create(AwsBasicCredentials.create(awsAccessKey,
awsSecretKey));
+ return withAWSClientsProvider(awsCredentialsProvider, region,
serviceEndpoint);
+ }
+
+ /**
+ * Specify {@link AwsCredentialsProvider} and region to be used to read
from Kinesis. If you
+ * need more sophisticated credential protocol, then you should look at
{@link
+ * Read#withAWSClientsProvider(AWSClientsProvider)}.
+ */
+ public Read withAWSClientsProvider(
Review comment:
👍 I added a new test class for the `Read` builder api here. Let me know
in case similar tests exist and i've just missed it
https://github.com/apache/beam/pull/15788/files#diff-16ffba2e35f48eeb476638eeab62a74b320c9ec9f30974336f183a0a36c5d3f2R36-R91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
