jrmccluskey commented on a change in pull request #15815:
URL: https://github.com/apache/beam/pull/15815#discussion_r737849490
##########
File path: sdks/go/pkg/beam/core/runtime/exec/pardo.go
##########
@@ -324,6 +324,11 @@ func (n *ParDo) postInvoke() error {
func (n *ParDo) fail(err error) error {
Review comment:
Adding the comment here for the record since we already talked offline:
the defer 100% will be added to the InvokeProcessFn() and InvokeDafaFn() cases
since we know we'll need to do that. I'll likely re-write the postInvoke() loop
to check if the cache has been instantiated too so we aren't sweating a
potential nil pointer exception if we got a panic beforehand.
The question remains as to how we handle potential errors being raised by
the deferred postInvoke() calls. It's a minor detail but I don't want to
accidentally hide errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
