TheNeuralBit commented on pull request #15820:
URL: https://github.com/apache/beam/pull/15820#issuecomment-953390594


   Note that this change attempts to replace our usages of `RelMetadataQuery` 
with `BeamRelMetadataQuery` everywhere, except for the places where we must use 
the base class to interface with Calcite. This results in a lot of boilerplate 
diff, which I tried to mostly contain in ecf8db2 for ease of review.
   
   Alternatively, we could continue to use `RelMetadataQuery` everywhere, and 
only cast to `BeamRelMetadataQuery` when necessary. Please let me know if you 
prefer this approach.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to