TheNeuralBit commented on pull request #15809: URL: https://github.com/apache/beam/pull/15809#issuecomment-955088276
Thanks @svetakvsundhar! Could you take a look at the failing PreCommit checks? - PythonDocs one may not be your problem - PythonLint = pylint, and PythonFormatter = yapf. There should be some info to help you run these on the Python Tips wiki page (if not let me know) Python PreCommit runs all the unit tests. It looks like your change actually breaks one of the tests in frames_test.py. We run some tests on all of the aggregation methods (including skew and kurtosis) in `AggregationTest`. It expects skew and kurtosis to not be parallelizable: https://github.com/apache/beam/blob/a5a0bd26ded0117240b2f6a967eb9f4c65209e6c/sdks/python/apache_beam/dataframe/frames_test.py#L1402-L1411 But you've fixed that now! To make these tests pass you should just need to remove skew from that list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
