pabloem commented on a change in pull request #15842:
URL: https://github.com/apache/beam/pull/15842#discussion_r740714418
##########
File path: playground/backend/internal/environment/application.go
##########
@@ -69,8 +74,13 @@ func NewCacheEnvs(cacheType, cacheAddress string,
cacheExpirationTime time.Durat
//ApplicationEnvs contains all environment variables that needed to run
backend processes
type ApplicationEnvs struct {
- workingDir string
- cacheEnvs *CacheEnvs
+ // workingDir is a root working directory of application
+ workingDir string
+
+ // cacheEnvs contains environments for cache
Review comment:
why is it that we can have multiple cacheEnvs?
##########
File path: playground/backend/internal/environment/application.go
##########
@@ -38,8 +38,13 @@ func (serverEnvs NetworkEnvs) Address() string {
//CacheEnvs contains all environment variables that needed to use cache
type CacheEnvs struct {
- cacheType string
- address string
+ // cacheType is type of cache (local/redis)
+ cacheType string
+
+ // address of where the cache is running
Review comment:
```suggestion
// this is a string with hostname:port of the cache server for redis
caches
```
##########
File path: playground/backend/internal/environment/application.go
##########
@@ -69,8 +74,13 @@ func NewCacheEnvs(cacheType, cacheAddress string,
cacheExpirationTime time.Durat
//ApplicationEnvs contains all environment variables that needed to run
backend processes
type ApplicationEnvs struct {
- workingDir string
- cacheEnvs *CacheEnvs
+ // workingDir is a root working directory of application
Review comment:
```suggestion
// workingDir is a root working directory of application..
// This directory is different from the `pwd` of the application. It is
a working directory passed as
// a parameter where the application stores code, executables, etc.
```
Let me know if this is correct, and if it is, feel free to apply it? : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
