lostluck commented on pull request #15881: URL: https://github.com/apache/beam/pull/15881#issuecomment-960247219
Agreed. If none of the scripts are run by the jenkins targets then it's unlikely they should be run as precommit. On Wed, Nov 3, 2021, 3:26 PM Kyle Weaver ***@***.***> wrote: > Java failure is incredibly unrelated, merging. > > Thanks Rebo. What do you think about excluding release/src/main/scripts/ > from Java/Python/etc. precommits? AFAIK these scripts are only intended to > be run by humans during the release, so there's no point in triggering > precommits for them. > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/15881#issuecomment-960242650>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADKDOFO5VJH4JKHFKBRFEF3UKHAJLANCNFSM5HJN7KSA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
