TheNeuralBit commented on a change in pull request #15638:
URL: https://github.com/apache/beam/pull/15638#discussion_r742418735
##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -652,7 +652,7 @@ class JavaJarExpansionService(object):
"""
def __init__(self, path_to_jar, extra_args=None):
if extra_args is None:
- extra_args = ['{{PORT}}']
+ extra_args = ['{{PORT}}', f'--filesToStage={path_to_jar}']
Review comment:
Ah actually I think the gradle target will get resolved to a URL (in
`BeamJarExpansionService.__init__`), but we'll pass the URL in filesToStage,
which won't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
