lukecwik commented on a change in pull request #15836:
URL: https://github.com/apache/beam/pull/15836#discussion_r742104648
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -53,10 +53,12 @@ def hadoopVersions = [
hadoopVersions.each {kv -> configurations.create("hadoopVersion$kv.key")}
dependencies {
+ // Required for processing Calcite's immutable annotations
Review comment:
If its only necessary for annotation processing consider adding it under
`annotationProcessor` and possibly `compileOnly` (only if its a dep as well)
like
[BeamModulePlugin.groovy](https://github.com/apache/beam/blob/48318dd3aedeb208648149eca36165bbfff09e1a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L966)
does.
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -53,10 +53,12 @@ def hadoopVersions = [
hadoopVersions.each {kv -> configurations.create("hadoopVersion$kv.key")}
dependencies {
+ // Required for processing Calcite's immutable annotations
Review comment:
If its only necessary for annotation processing consider adding it under
`annotationProcessor` and possibly `compileOnly` (only if its a dep as well)
like
[BeamModulePlugin.groovy](https://github.com/apache/beam/blob/48318dd3aedeb208648149eca36165bbfff09e1a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L966)
does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
