chamikaramj commented on a change in pull request #15889:
URL: https://github.com/apache/beam/pull/15889#discussion_r742450075
##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -670,7 +670,8 @@ def __enter__(self):
self._service_provider = subprocess_server.JavaJarServer(
ExpansionAndArtifactRetrievalStub,
self._path_to_jar,
- self._extra_args)
+ self._extra_args + [f'--filesToStage={self._path_to_jar}'],
Review comment:
I would keep the same behavior.
cc: @robertwb
##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -670,7 +670,8 @@ def __enter__(self):
self._service_provider = subprocess_server.JavaJarServer(
ExpansionAndArtifactRetrievalStub,
self._path_to_jar,
- self._extra_args)
+ self._extra_args + [f'--filesToStage={self._path_to_jar}'],
Review comment:
nit: remove extra ","
##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -670,7 +670,8 @@ def __enter__(self):
self._service_provider = subprocess_server.JavaJarServer(
ExpansionAndArtifactRetrievalStub,
self._path_to_jar,
- self._extra_args)
+ self._extra_args + [f'--filesToStage={self._path_to_jar}'],
Review comment:
Sounds good. LGTMed https://github.com/apache/beam/pull/15891. To be
clear I think this is a true regression/blocker. IIUC this will break x-lang
wrappers in production.
##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -670,7 +670,8 @@ def __enter__(self):
self._service_provider = subprocess_server.JavaJarServer(
ExpansionAndArtifactRetrievalStub,
self._path_to_jar,
- self._extra_args)
+ self._extra_args + [f'--filesToStage={self._path_to_jar}'],
Review comment:
I would keep the same behavior.
cc: @robertwb
##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -670,7 +670,8 @@ def __enter__(self):
self._service_provider = subprocess_server.JavaJarServer(
ExpansionAndArtifactRetrievalStub,
self._path_to_jar,
- self._extra_args)
+ self._extra_args + [f'--filesToStage={self._path_to_jar}'],
Review comment:
nit: remove extra ","
##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -670,7 +670,8 @@ def __enter__(self):
self._service_provider = subprocess_server.JavaJarServer(
ExpansionAndArtifactRetrievalStub,
self._path_to_jar,
- self._extra_args)
+ self._extra_args + [f'--filesToStage={self._path_to_jar}'],
Review comment:
Sounds good. LGTMed https://github.com/apache/beam/pull/15891. To be
clear I think this is a true regression/blocker. IIUC this will break x-lang
wrappers in production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
