robertwb commented on a change in pull request #15638:
URL: https://github.com/apache/beam/pull/15638#discussion_r742460684
##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -652,7 +652,7 @@ class JavaJarExpansionService(object):
"""
def __init__(self, path_to_jar, extra_args=None):
if extra_args is None:
- extra_args = ['{{PORT}}']
+ extra_args = ['{{PORT}}', f'--filesToStage={path_to_jar}']
Review comment:
Good point. (In a dev branch it resolves to a local file, but that's a
special case...)
##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -652,7 +652,7 @@ class JavaJarExpansionService(object):
"""
def __init__(self, path_to_jar, extra_args=None):
if extra_args is None:
- extra_args = ['{{PORT}}']
+ extra_args = ['{{PORT}}', f'--filesToStage={path_to_jar}']
Review comment:
Good point. I'll create a fix.
##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -652,7 +652,7 @@ class JavaJarExpansionService(object):
"""
def __init__(self, path_to_jar, extra_args=None):
if extra_args is None:
- extra_args = ['{{PORT}}']
+ extra_args = ['{{PORT}}', f'--filesToStage={path_to_jar}']
Review comment:
https://github.com/apache/beam/pull/15891
(FWIW, it did handle gradle path resolution, which was tested, but just not
remote http://staged/sql/expansionservice.jar, i.e. the
`JavaJarServer.local_jar` part.)
##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -652,7 +652,7 @@ class JavaJarExpansionService(object):
"""
def __init__(self, path_to_jar, extra_args=None):
if extra_args is None:
- extra_args = ['{{PORT}}']
+ extra_args = ['{{PORT}}', f'--filesToStage={path_to_jar}']
Review comment:
Good point. (In a dev branch it resolves to a local file, but that's a
special case...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
