mosche commented on a change in pull request #15910:
URL: https://github.com/apache/beam/pull/15910#discussion_r743784126
##########
File path:
sdks/java/io/amazon-web-services/src/test/java/org/apache/beam/sdk/io/aws/sns/SnsIOTest.java
##########
@@ -114,7 +118,10 @@ public void testDataWritesToSNS() {
@Test
public void testRetries() throws Throwable {
+ thrown.expect(IOException.class);
thrown.expectMessage("Error writing to SNS");
+ thrown.expectMessage("No more attempts allowed");
Review comment:
Each `expectMessage` is just a `contains` check for the message. In this
case the assertion error thrown if the logs did not exist also contained the
first string :/ So the 2nd one is really the one we are looking for here as it
indicates that we've given up retrying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
