MiguelAnzoWizeline commented on pull request #15549: URL: https://github.com/apache/beam/pull/15549#issuecomment-963281851
@lukecwik Hi, I was testing the implementation that we considered in the previous message, using an internal ByteKeyRangeTracker gave me some problems with keeping the range, lastAttemptedKey and lastClaimedKey updated correctly. The implementation with the new changes I commited works by having a ByteKey in RedisCursor along with the String cursor representation, and RedisCursorRangeTracker copies the functionality of ByteKeyRangeTracker (with the added special conditions of the Redis implementation) using the ByteKey representation of the cursor to keep track of the range, this works well for all the read test and seems a cleaner approach. Still missing the unit test for the new code. I wanted to see first if the changes looks correct to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
