lostluck commented on a change in pull request #15923:
URL: https://github.com/apache/beam/pull/15923#discussion_r746097673
##########
File path: sdks/go/pkg/beam/runners/dataflow/dataflowlib/metrics.go
##########
@@ -33,7 +33,7 @@ func FromMetricUpdates(allMetrics []*df.MetricUpdate, p
*pipepb.Pipeline) *metri
ac, ad := groupByType(allMetrics, p, true)
cc, cd := groupByType(allMetrics, p, false)
- return metrics.NewResults(metrics.MergeCounters(ac, cc),
metrics.MergeDistributions(ad, cd), make([]metrics.GaugeResult, 0),
make([]metrics.MsecResult, 0))
+ return metrics.NewResults(metrics.MergeCounters(ac, cc),
metrics.MergeDistributions(ad, cd), make([]metrics.GaugeResult, 0),
make([]metrics.MsecResult, 0), make([]metrics.PColResult, 0))
Review comment:
In a later PR, we should properly hook up the Msec and PCollection
metrics from Dataflow results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
