tvalentyn commented on a change in pull request #15901:
URL: https://github.com/apache/beam/pull/15901#discussion_r746104630
##########
File path: sdks/python/apache_beam/io/textio.py
##########
@@ -362,6 +391,15 @@ def _is_self_overlapping(delimiter):
return True
return False
+ def _is_escaped(self, read_buffer, position):
+ # Returns True if byte at position is preceded with an odd number
+ # of escapechar bytes or False if preceded by 0 or even escapes
+ # (the even number means that all the escapes are escaped themselves).
+ for current_pos in reversed(range(-1, position)):
+ if read_buffer.data[current_pos:current_pos + 1] != self._escapechar:
Review comment:
Thanks.
I personally like `explicit is better than implicit` from
https://www.python.org/dev/peps/pep-0020/ . Someone reading this code might
wonder whether [-1:0] range was an intentional choice to test implicitly test
edge case, or it's an off-by-one error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
