TheNeuralBit commented on a change in pull request #15742:
URL: https://github.com/apache/beam/pull/15742#discussion_r746165575
##########
File path:
runners/core-java/src/test/java/org/apache/beam/runners/core/SimpleDoFnRunnerTest.java
##########
@@ -391,6 +391,7 @@ public void testInfiniteSkew() {
static final String TIMER_ID = "throwingTimerId";
+ @SuppressWarnings("unused")
Review comment:
Ok I was able to make a change to error-prone to make it suppress this
warning for TimerId and StateId:
https://github.com/google/error-prone/commit/fad4116129fcbaa5e3418ff419f164552f75481a
We can't take advantage of that until it is in an error-prone release
though. We _can_ go ahead and merge PRs that remove unused variables though, so
that we're ready to turn the check on when that fix is released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
