tvalentyn commented on a change in pull request #15866:
URL: https://github.com/apache/beam/pull/15866#discussion_r746199629
##########
File path: sdks/python/gen_protos.py
##########
@@ -336,11 +336,19 @@ def generate_proto_files(force=False, log=None):
for path in MODEL_RESOURCES:
shutil.copy2(os.path.join(py_sdk_root, path), out_dir)
- ret_code = subprocess.call(
- ["futurize", "--both-stages", "--write", "--no-diff", out_dir])
- if ret_code:
- raise RuntimeError(
- 'Error applying futurize to generated protobuf python files.')
+ # see: https://github.com/protocolbuffers/protobuf/issues/1491
+ # force relative import paths for proto files
+ for filename in os.listdir(out_dir):
Review comment:
looks like this the only place where future was still useful.. did
futurize pick up *.pyi files as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
