TheNeuralBit commented on pull request #15915:
URL: https://github.com/apache/beam/pull/15915#issuecomment-965578619


   I haven't looked at the actual implementation but I do have a high-level 
question about the API:
   
   ```
           input.apply(SqlTransform.query(query)
                   .withErrorsTransformer(new  BeamSqlErrorTransformer())
                   .registerUdf("func1", Func1.class)
                   .registerUdf("func2", Func2.class)
   ```
   
   This API looks odd to me. I think it could be more familiar to Beam users if 
there were an option to make SqlTransform return a tagged PCollection, with one 
of the PCollections representing error information for failed records.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to