lostluck commented on a change in pull request #15928: URL: https://github.com/apache/beam/pull/15928#discussion_r746935017
########## File path: sdks/go/pkg/beam/util/harnessopts/sampler.go ########## @@ -0,0 +1,38 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// Package harnessopts defines user-facing entrypoints into Beam hooks +// affecting the SDK harness. Call these functions at any time before +// submitting your pipeline to a runner, for that pipeline's workers to be affected. +package harnessopts + +import ( + "strconv" + "time" + + "github.com/apache/beam/sdks/v2/go/pkg/beam/core/util/hooks" +) + +const ( + samplePeriodHook = "beam:go:hook:dofnmetrics:sampletime" +) + +// SampleInterval sets the sampling time period for DoFn metrics sampling. +// Default value is 200ms. +func SampleInterval(samplePeriod time.Duration) error { + sampleTime := strconv.FormatInt(int64(samplePeriod), 10) Review comment: Instead of designing your own format, consider just using the built in conversions for time.Duration to string. eg. the String representation of Duration, and `time.ParseDuration` https://play.golang.org/p/RWuZzIkwHD0 So this side would use samplePeriod.String() ########## File path: sdks/go/pkg/beam/util/harnessopts/sampler.go ########## @@ -0,0 +1,38 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// Package harnessopts defines user-facing entrypoints into Beam hooks +// affecting the SDK harness. Call these functions at any time before +// submitting your pipeline to a runner, for that pipeline's workers to be affected. +package harnessopts + +import ( + "strconv" + "time" + + "github.com/apache/beam/sdks/v2/go/pkg/beam/core/util/hooks" +) + +const ( + samplePeriodHook = "beam:go:hook:dofnmetrics:sampletime" +) + +// SampleInterval sets the sampling time period for DoFn metrics sampling. +// Default value is 200ms. +func SampleInterval(samplePeriod time.Duration) error { Review comment: Please validate that the samplePeriod is > 1ms, since we don't want to deal with samples of smaller granularity. Return an error if not. ########## File path: sdks/go/pkg/beam/core/runtime/harness/sampler_hook.go ########## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package harness + +import ( + "context" + "fmt" + "time" + + "github.com/apache/beam/sdks/v2/go/pkg/beam/core/util/hooks" +) + +var ( + samplePeriod time.Duration = 200 * time.Millisecond +) + +func init() { + hf := func(opts []string) hooks.Hook { + return hooks.Hook{ + Init: func(ctx context.Context) (context.Context, error) { + if len(opts) == 0 { + return ctx, nil + } + if len(opts) > 1 { + return ctx, fmt.Errorf("expected 1 option, got %v: %v", len(opts), opts) + } + + var sampleTime time.Duration + _, err := fmt.Sscan(opts[0], &sampleTime) Review comment: On this side, instead of using `fmt.Sscan`, use `time.ParseDuration` instead. (see my other comment for clarity). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
