AydarZaynutdinov commented on a change in pull request #15926:
URL: https://github.com/apache/beam/pull/15926#discussion_r747424345
##########
File path: playground/backend/cmd/server/controller.go
##########
@@ -366,29 +351,64 @@ func processCode(ctx context.Context, cacheService
cache.Cache, lc *fs_tool.Life
}
}(successChannel, errorChannel, dataChannel)
+ processStep(ctxWithTimeout, pipelineId, cacheService, cancelChan,
successChannel, dataChannel, errorChannel, pb.Status_STATUS_RUN_ERROR,
pb.Status_STATUS_FINISHED)
+}
+
+// processStep processes each executor's step with cancel and timeout checks.
+// If finishes by canceling, timeout or error - returns false.
+// If finishes successfully returns true.
+func processStep(ctx context.Context, pipelineId uuid.UUID, cacheService
cache.Cache, cancelChan, successChan chan bool, dataChan chan interface{},
errorChannel chan error, errorCaseStatus, successCaseStatus pb.Status) bool {
Review comment:
Renamed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
